This repository was archived by the owner on Sep 23, 2024. It is now read-only.
fix methods to infer geom and bbox #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @TomAugspurger, I recently used stac table to create a STAC collection for a parquet dataset. Doing so I made some minor changes to the package. Please have a look if you would like to keep them.
In the source code I saw some TODO comments about 'maybe converting the geometries to EPSG:4326'. Since my data was in EPSG:3857, I added the reprojection for the geometries that fall directly under the pystac.Item.properties. So the geometries/bbox are now in 4326, whereas the ones under the projection prefix are in the CRS of the source data.
For some conditions, the data was being load using
dask_geopandas.read_paquet()
; but at least for my dataset the spatial partitions were not available without computing them first. What do you think about adding a call to calculate_spatial_partitions()?