This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @TomAugspurger , we have been using stac-table for our project and it has been amazing, thanks for your work!
Using stac-table I have realised that the types returned were based on physical types rather than logical. This is not great to know what the data is because for example both string and bytes show as
byte_array
and both datetimes and integers show asint64
.This PR changes it so that the logical type is used whenever possible, I hope this can be a useful change.
Note: I have also needed to change the types of two columns in the tests to get them to pass before doing any changes to the code, I suspect that the "naturalearth_lowres" dataset in geopandas may have gotten updated at some point. It is also going to be deprecated in the future, so eventually the source data for this test should probably be included in the package.