Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep original filenames #77

Merged
merged 5 commits into from
Jan 17, 2024

Conversation

ircwaves
Copy link
Member

Closes #6

CHANGELOG.md Outdated Show resolved Hide resolved
@ircwaves ircwaves marked this pull request as ready for review January 10, 2024 12:59
@ircwaves
Copy link
Member Author

ircwaves commented Jan 10, 2024

@matthewhanson @gadomski agree that porting to stac-asset (#76) is definitely the better long-term move, but for immediate GTD, I believe this addresses the issue in the interim.

@gadomski gadomski self-requested a review January 10, 2024 13:06
@ircwaves ircwaves force-pushed the irc/6-keep-original-filenames branch from 40f5ae5 to 6e18a66 Compare January 10, 2024 13:07
pyproject.toml Outdated Show resolved Hide resolved
@ircwaves ircwaves force-pushed the irc/6-keep-original-filenames branch from 6e18a66 to 952d4b7 Compare January 10, 2024 13:10
Closes stac-utils#6

Update CHANGELOG.md

ignore .python-version file for pyenv-virtualenv
keep_original_filenames is task specific, not invocation specific
@ircwaves ircwaves force-pushed the irc/6-keep-original-filenames branch from 1816d54 to 23906b2 Compare January 11, 2024 20:17
CHANGELOG.md Outdated Show resolved Hide resolved
@gadomski gadomski enabled auto-merge (squash) January 17, 2024 13:32
@gadomski gadomski merged commit 96fc203 into stac-utils:main Jan 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to download assets with original filename
2 participants