-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STAC Client pagination support #327
Merged
pomadchin
merged 5 commits into
stac-utils:master
from
pomadchin:feature/client-streams
May 24, 2021
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8dff236
StacClient supports pagination and has fs2.Streams in the interface
pomadchin ee4e0d8
Cleanup PaginationToken companion object
pomadchin 95b382f
Split StacClient and StreamingStacClient
pomadchin 5648aea
Make a StreamingStacClient G independent from F; finish search pagina…
pomadchin e85ee2f
Rename type alias
pomadchin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 0 additions & 3 deletions
3
modules/client/js/src/main/scala/com/azavea/stac4s/api/client/StacClient.scala
This file was deleted.
Oops, something went wrong.
4 changes: 2 additions & 2 deletions
4
modules/client/js/src/main/scala/com/azavea/stac4s/api/client/SttpStacClient.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
package com.azavea.stac4s.api.client | ||
|
||
import cats.MonadError | ||
import cats.MonadThrow | ||
import sttp.client3.SttpBackend | ||
import sttp.model.Uri | ||
|
||
object SttpStacClient { | ||
|
||
def apply[F[_]: MonadError[*[_], Throwable]](client: SttpBackend[F, Any], baseUri: Uri): SttpStacClient[F] = | ||
def apply[F[_]: MonadThrow](client: SttpBackend[F, Any], baseUri: Uri): SttpStacClient[F] = | ||
SttpStacClientF[F, SearchFilters](client, baseUri) | ||
} |
5 changes: 4 additions & 1 deletion
5
modules/client/js/src/main/scala/com/azavea/stac4s/api/client/package.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,8 @@ | ||
package com.azavea.stac4s.api | ||
|
||
package object client { | ||
type SttpStacClient[F[_]] = SttpStacClientF[F, SearchFilters] | ||
type SttpStacClient[F[_]] = SttpStacClientF[F, SearchFilters] | ||
type StacClient[F[_]] = StacClientF[F, SearchFilters] | ||
type StreamingStacClientFS2[F[_]] = StreamingStacClientF[F, fs2.Stream[F, *], SearchFilters] | ||
type StreamingStacClient[F[_], G[_]] = StreamingStacClientF[F, G, SearchFilters] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 0 additions & 3 deletions
3
modules/client/jvm/src/main/scala/com/azavea/stac4s/api/client/StacClient.scala
This file was deleted.
Oops, something went wrong.
4 changes: 2 additions & 2 deletions
4
modules/client/jvm/src/main/scala/com/azavea/stac4s/api/client/SttpStacClient.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
package com.azavea.stac4s.api.client | ||
|
||
import cats.MonadError | ||
import cats.MonadThrow | ||
import sttp.client3.SttpBackend | ||
import sttp.model.Uri | ||
|
||
object SttpStacClient { | ||
|
||
def apply[F[_]: MonadError[*[_], Throwable]](client: SttpBackend[F, Any], baseUri: Uri): SttpStacClient[F] = | ||
def apply[F[_]: MonadThrow](client: SttpBackend[F, Any], baseUri: Uri): SttpStacClient[F] = | ||
SttpStacClientF[F, SearchFilters](client, baseUri) | ||
} |
5 changes: 0 additions & 5 deletions
5
modules/client/jvm/src/main/scala/com/azavea/stac4s/api/client/client.scala
This file was deleted.
Oops, something went wrong.
8 changes: 8 additions & 0 deletions
8
modules/client/jvm/src/main/scala/com/azavea/stac4s/api/client/package.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
package com.azavea.stac4s.api | ||
|
||
package object client { | ||
type SttpStacClient[F[_]] = SttpStacClientF[F, SearchFilters] | ||
type StacClient[F[_]] = StacClientF[F, SearchFilters] | ||
type StreamingStacClientFS2[F[_]] = StreamingStacClientF[F, fs2.Stream[F, *], SearchFilters] | ||
type StreamingStacClient[F[_], G[_]] = StreamingStacClientF[F, G, SearchFilters] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
G
here is a separate parameter to make it independent fromF
.