Skip to content

Conversation

matthewscottgordon
Copy link

Related Issue(s):
#477

Description:
Moved the requests dependency from optional-dependencies.dev to dependencies.

The requests package is used by the test_data module which is loaded by load_plugins() when you run stac. I'm not sure if this the right way to fix this; it's possible that that module shouldn't be loaded to begin with.

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Changes are added to the CHANGELOG.

@gadomski
Copy link
Member

@matthewscottgordon CI failures aren't on you, this repo has a bit of bitrot. I'll try to clean things up today or tomorrow. Thanks for the contribution! After this is merged we can cut a new release.

@gadomski gadomski enabled auto-merge (squash) December 23, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stac command crashes when installed in clean venv without [validate] option

2 participants