-
-
Couldn't load subscription status.
- Fork 3
feat: Support configuring ListenerClass preset (with sensible defaults) #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| /// This argument is likely temporary until we support setting arbitrary helm values for the | ||
| /// operators! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think even then, there is a valid case to keep it as a shortcut.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in 3019ae3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some recommended changes.
I will update the PR description.
I also think "preset" should be plural: "presets", but that's outside of the scope of this and would need to change in the chart.
rust/stackable-cockpit/src/platform/operator/listener_operator.rs
Outdated
Show resolved
Hide resolved
rust/stackable-cockpit/src/platform/operator/listener_operator.rs
Outdated
Show resolved
Hide resolved
rust/stackable-cockpit/src/platform/operator/listener_operator.rs
Outdated
Show resolved
Hide resolved
rust/stackable-cockpit/src/platform/operator/listener_operator.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Nick <[email protected]>
Co-authored-by: Nick <[email protected]>
Co-authored-by: Nick <[email protected]>
Hmm, I think preset is technically more correct, as it's e.g. "stable-nodes". |
Description
Part of stackabletech/issues#770
With recent changes from stackabletech/issues#770,
stackablectl demo installon kind broke, as kind by default does not have a LoadBalancer installed.We could try to document/automate/whatnot this, but I expect significant user problems with this. So instead we can make stackablectl a little bit more clever and detect kind and k3s and don't use LoadBalancers in that case.
stackablectl now tries the following order and simple passes the result to the listener-operator helm-chart:
--listener-class-presetflagPS: Yes I know the
OnceCellis not ideal, but I hope this is a temporary feature until #406 is implemented properly.Definition of Done Checklist
Author
Reviewer
Acceptance