Skip to content

Conversation

dmartinol
Copy link
Collaborator

Addresses the docs part of #1749

Signed-off-by: Daniele Martinoli <[email protected]>
@dmartinol dmartinol requested a review from jhrozek September 29, 2025 15:57
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.29%. Comparing base (9299e30) to head (8ebcdcd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2027      +/-   ##
==========================================
+ Coverage   48.28%   48.29%   +0.01%     
==========================================
  Files         238      238              
  Lines       29952    29952              
==========================================
+ Hits        14461    14465       +4     
+ Misses      14388    14385       -3     
+ Partials     1103     1102       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JAORMX JAORMX requested a review from Copilot October 2, 2025 12:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive documentation for the MCPRegistry CRD, which is an experimental feature for managing MCP server registries in Kubernetes. The documentation covers the architecture, usage patterns, and operational aspects of the registry system.

  • Introduces complete MCPRegistry documentation with configuration examples and operational guidance
  • Updates existing operator documentation to reference the new registry capabilities
  • Provides architectural context and development patterns for the registry feature

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
cmd/thv-operator/REGISTRY.md Complete MCPRegistry reference documentation covering API, configuration, and troubleshooting
cmd/thv-operator/README.md Updated operator overview to include MCPRegistry features and installation options
cmd/thv-operator/DESIGN.md Added architectural decisions and design patterns specific to MCPRegistry
cmd/thv-operator/CLAUDE.md Developer documentation for MCPRegistry development patterns and testing
README.md Updated main README to highlight Kubernetes operator capabilities

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +126 to +128
**E2E Tests (🔄 Missing for MCPRegistry)**:
- Chainsaw framework ready but no MCPRegistry tests yet
- MCPServer E2E tests exist as reference
Copy link
Preview

Copilot AI Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The status indicates MCPRegistry E2E tests are missing, but this appears to be documenting current state rather than identifying a problem that needs fixing in this PR.

Copilot uses AI. Check for mistakes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Anyway, I need to update this PR after the recent changes due to E2E tests

@dmartinol
Copy link
Collaborator Author

Note: CI failures will be solved once we merge the e2e test PR which has important changes also tracked in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant