Support swift 5.9+ syntax.

[furby-tm]

This revision adds support for Swift Syntax 5.9 and above.

Important

It also points to the latest revision of @stackotter's fork of swift-argument-parser, which otherwise conflicts with the name of the GenerateManual plugin if not brought to that version. As well as updating the swift-log dependency to the latest v1.5.4.

[furby-tm]

Note, there are some misc. minor deprecation warnings with some of the existing SwiftSyntax usage but wanted to keep this revision low-touch, and specific to breaking changes with the upgrade from 5.8 → 5.10.

[stackotter]

If you've tested schema-gen and it still produces the same output as it did before your changes, then I'm happy to merge with that one minor formatting change (for the guard statement that I commented on).

[furby-tm]

@stackotter When I run:

./generate_schema.sh

I receive the following output:

Enum 'PlistValue' requires an explicit schema

And the entirety of Bundler.schema.json gets deleted, lol. I guess something got messed up...

[stackotter]

@stackotter When I run:

./generate_schema.sh

I receive the following output:

Enum 'PlistValue' requires an explicit schema

And the entirety of Bundler.schema.json gets deleted, lol. I guess something got messed up...

lol whoops, yeah it works for me (on the commit before your changes), must've messed up something in the explicit schema parsing stuff (cause it's true that PlistValue requires an explicit schema, but it's also true that one is provided in its doc comment).

[furby-tm]

@stackotter actually the deprecations were so stupidly minimal I've included them as well to void stupid warnings, they were simple renamings.

~ also ew, I am unsure why my rebase committed your commits under my name 😕

this is why we make branches, and do not work out of main 😅 I should have put this in a feature branch 🤦🏻‍♀️.

[furby-tm]

Important

Do not merge until ./generate_schema.sh runs successfully without file changes.

[furby-tm]

All fixed, due to my dumb guard in .parse(from:), which caused an early return due to the lack of any leadingTrivia, which I later realized was only for the purposes of documentation parsing. Feel free to merge @stackotter 👍🏻

[furby-tm]

Also, since parsing the documentation alone was half the logic in the parse(from:) function, it was making the core parsing logic unclear, I opted to move documentation parsing into it's own function: parseDocumentation(from:), and the guard was removed from parse(from:) because we still want the property parsed even if there is no doc comment.

[stackotter]

Remove needless stack allocation for docs.

The ultimate premature optimisation 😅 (don't think that affects performance at all, swiftc rearranges things and the stack is constant sized within a function, see this godbolt experiment).

Lgtm 👍

[furby-tm]

Remove needless stack allocation for docs.

The ultimate premature optimisation 😅 (don't think that affects performance at all, swiftc rearranges things and the stack is constant sized within a function, see this godbolt experiment).

Lgtm 👍

@stackotter
C++ has given me some terrible PTSD when it comes to recognizing certain design patterns, that I can never unsee 😅 To be honest, I wasn't aware swiftc was that smart, lol!

[stackotter]

To be honest, I wasn't aware swiftc was that smart, lol!

Hahah yeah it's pretty smart, today I found out some pretty cool tricks it uses to optimise converting enums to raw values (and vice versa)

[furby-tm]

I found out some pretty cool tricks it [swiftc] uses to optimise converting enums to raw values (and vice versa)

@stackotter Too much greatness 😭 How so?

[stackotter]

enum A: UInt8 {
    case one = 2
    case two = 3
    case three = 5
    case four = 7
    case five = 11
    case six = 13
    case seven = 17
}

Under the hood A.one is represented as the byte 0, and A.two is represented as the byte 1 (not sure what the implementation reason is, could be for ABI stability) and so on.

The function that computes A.rawValue is just just 3 instructions (to map the numbers 0..<7 to the seven corresponding raw values). It stores all the raw values in one big UInt64 and uses bit shifting to extract each of the values.

output.A.rawValue.getter : Swift.UInt8:
        lea     ecx, [8*rdi]
        movabs  rax, 4799415617651458
        shr     rax, cl
        ret

And for an enum such as B (below) it figures out the pattern and computes it in just two instructions,

enum B: UInt8 {
  case one = 1
  case two = 4
  case three = 7
  case four = 10
}

output.A.rawValue.getter : Swift.UInt8:
        lea     eax, [rdi + 2*rdi]
        inc     al
        ret