Adds ansible-lint GHA step in lint workflow #1281
Conversation
| - "Pushed the following images:" | ||
| - " {{ collector_image }}-{{ arch }}-slim" | ||
| - " {{ collector_image }}-{{ arch }}-base" | ||
| - " {{ ansible_env.RHACS_ENG_IMAGE }}-{{ arch }}-slim" | ||
| - " {{ ansible_env.RHACS_ENG_IMAGE }}-{{ arch }}-base" |
There was a problem hiding this comment.
Dang, I prefer arrays to be in the same line for the object, but OK.
| when: not python_exists | ||
| - when: not python_exists | ||
| creates: /usr/bin/python3 | ||
| block: |
| delay: 10 | ||
| sleep: 10 | ||
| timeout: 60 | ||
| - name: Wait for reboot to complete |
There was a problem hiding this comment.
Just to be extra clear, we don't need to reboot if the interpreter was already installed, which we were doing before, right?
There was a problem hiding this comment.
Yeah we were always rebooting before, but that only needs to happen when we've attempted to install a package (it's not applied until the machine reboots) so now it's more precise in its behaviour
| @@ -3,11 +3,18 @@ | |||
| set_fact: | |||
| distro: "centos" | |||
|
|
|||
| - name: Install yum utils | |||
There was a problem hiding this comment.
Wonder what lint error triggered this code block to suddenly appear.
There was a problem hiding this comment.
there's a rule that analyses scripts (shell and command blocks) for commands that have a pre-existing ansible task. Since we were manually using yum in the shell below, it was flagging on that. It's also why the use of make has now changed in some other the other playbooks
|
Stringy
force-pushed
the
giles/ansible-lint-integration
branch
from
5e398ef to
615945e
Compare
Stringy
force-pushed
the
giles/ansible-lint-integration
branch
from
bf1aec4 to
3d8efde
Compare
Description
Adds ansible-lint to CI to improve our ansible quality, especially now that our playbooks and roles are expanding for multi-arch.
This PR will also fix any lint errors that are introduced by this addition.
Checklist