-
Notifications
You must be signed in to change notification settings - Fork 28
Remove all driver related files #2124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Molter73 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2124 +/- ##
=======================================
Coverage 28.83% 28.83%
=======================================
Files 96 96
Lines 5799 5799
Branches 2551 2551
=======================================
Hits 1672 1672
Misses 3408 3408
Partials 719 719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
These files are used to correlate collector versions to stackrox versions, main use for it was to create the index directory for support-packages. Since support-packages have been deprecated since 4.4, there's not much point in keeping these files updated anymore and the only purpose it seems to serve is taking up release engineers time ping-ponging a PR that gets a rubber-stamped "approved" and merge from the collector team. Hence, we are removing the files from the collector repo altogether. Correlating versions between stackrox and collector can be achieved using the following command in the main repo: `git show <tag>:COLLECTOR_VERSION` I will add that command to our documentation as part of a larger cleanup.
And by extension all scripts, files and actions related to drivers.
79e36b7
to
fdeac2b
Compare
Description
Kernel modules and eBPF probes (collectively known as "drivers"), have been deprecated for quite some time and the last versions that still supported them have reached EOL. As such, we shouldn't have to update them anymore.
This PR gets rid of all the leftover scripts that downloaded drivers, uploaded them to GCP, packaged them as support-packages, uploaded those to GCP, created the index for the CDN page, etc.
We also remove the
RELEASED_VERSIONS
,RELEASED_VERSIONS.unsupported
andKERNEL_VERSIONS
files, these were only used for driver and support-package related tasks and are now pointless. Correlating versions between stackrox and collector can be achieved using the following command in the main repo:git show <tag>:COLLECTOR_VERSION
I will add that command to our documentation as part of a separate doc cleanup PR (I think this one is large enough as is).
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
CI should be enough.