-
Notifications
You must be signed in to change notification settings - Fork 158
refactor(ui): migrate PolicyCategoriesSelectField to PatternFly v5 #16437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: saif/policies-select-migration
Are you sure you want to change the base?
refactor(ui): migrate PolicyCategoriesSelectField to PatternFly v5 #16437
Conversation
Signed-off-by: Saif Chaudhry <[email protected]>
Skipping CI for Draft Pull Request. |
Caution There are some errors in your PipelineRun template.
|
Signed-off-by: Saif Chaudhry <[email protected]>
Images are ready for the commit at c5d03b3. To use with deploy scripts, first |
Signed-off-by: Saif Chaudhry <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## saif/policies-select-migration #16437 +/- ##
===============================================================
Coverage 49.07% 49.07%
===============================================================
Files 2640 2640
Lines 195714 195714
===============================================================
+ Hits 96048 96052 +4
+ Misses 92153 92150 -3
+ Partials 7513 7512 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Saif Chaudhry <[email protected]>
Signed-off-by: Saif Chaudhry <[email protected]>
… selection Signed-off-by: Saif Chaudhry <[email protected]>
…ries Signed-off-by: Saif Chaudhry <[email protected]>
Description
Refactor PolicyCategoriesSelectField component to migrate from deprecated Select to PatternFly v5 Select with modern typeahead multi-select functionality.
I made a decision not to try to modify any wrapper components (i.e., SelectSingle, TypeaheadSelect, etc.) or create any new wrapper components for this use case. We could probably benefit from having a MultiTypeaheadSelect. I'll wait to see if we have more than 3 use cases for it before I consider making one.
Key Changes:
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Before
before-policy-categories-select-field.mov
After
after-policy-categories-select-field.mov