Skip to content

Feat/signer two phase commit #6082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jferrant
Copy link
Contributor

@jferrant jferrant commented May 5, 2025

Closes #6099

@jferrant jferrant force-pushed the feat/signer-two-phase-commit branch 2 times, most recently from 3156089 to c7dc731 Compare May 5, 2025 22:29
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant jferrant force-pushed the feat/signer-two-phase-commit branch from c7dc731 to 05285b2 Compare May 6, 2025 00:48
Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 66.85714% with 116 lines in your changes missing coverage. Please review.

Project coverage is 77.76%. Comparing base (32461ef) to head (d37a3f6).
Report is 127 commits behind head on develop.

Files with missing lines Patch % Lines
stacks-node/src/tests/signer/v0.rs 24.57% 89 Missing ⚠️
stacks-signer/src/v0/signer.rs 84.61% 18 Missing ⚠️
libsigner/src/v0/messages.rs 40.00% 9 Missing ⚠️

❌ Your project status has failed because the head coverage (77.76%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6082      +/-   ##
===========================================
+ Coverage    76.77%   77.76%   +0.99%     
===========================================
  Files          545      545              
  Lines       347417   347709     +292     
  Branches       323      323              
===========================================
+ Hits        266719   270405    +3686     
+ Misses       80690    77296    -3394     
  Partials         8        8              
Files with missing lines Coverage Δ
...tacks-node/src/nakamoto_node/stackerdb_listener.rs 84.25% <100.00%> (+0.04%) ⬆️
stacks-signer/src/chainstate/mod.rs 90.56% <ø> (-1.14%) ⬇️
stacks-signer/src/monitoring/mod.rs 86.45% <100.00%> (+0.43%) ⬆️
stacks-signer/src/monitoring/prometheus.rs 100.00% <ø> (ø)
stacks-signer/src/signerdb.rs 84.50% <100.00%> (-2.30%) ⬇️
stacks-signer/src/v0/tests.rs 89.00% <100.00%> (-0.42%) ⬇️
libsigner/src/v0/messages.rs 83.19% <40.00%> (+5.43%) ⬆️
stacks-signer/src/v0/signer.rs 79.76% <84.61%> (-1.91%) ⬇️
stacks-node/src/tests/signer/v0.rs 36.60% <24.57%> (+3.01%) ⬆️

... and 299 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32461ef...d37a3f6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jferrant jferrant marked this pull request as ready for review July 10, 2025 17:43
@jferrant jferrant requested review from a team as code owners July 10, 2025 17:43
@jferrant jferrant self-assigned this Jul 10, 2025
Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant jferrant marked this pull request as draft July 10, 2025 21:06
Signed-off-by: Jacinta Ferrant <[email protected]>
@hstove hstove linked an issue Jul 21, 2025 that may be closed by this pull request
@jferrant
Copy link
Contributor Author

Replaced by #6319

@jferrant jferrant closed this Jul 21, 2025
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signer State Agreement: Two Phase Commit
1 participant