Skip to content

Feat/signer state machine rollout #6215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jferrant
Copy link
Contributor

@jferrant jferrant commented Jun 20, 2025

Closes #6092

Note disallow_reorg_within_first_proposal_burn_block_timing_secs_but_more_than_one_block_scenario will be flaky until #6221 is fixed

@jferrant jferrant force-pushed the feat/signer-state-machine-rollout branch from 58f8f12 to 0d44833 Compare June 20, 2025 20:53
Copy link

codecov bot commented Jun 21, 2025

Codecov Report

Attention: Patch coverage is 81.04647% with 518 lines in your changes missing coverage. Please review.

Project coverage is 82.14%. Comparing base (d4980dd) to head (34eb466).
Report is 48 commits behind head on develop.

Files with missing lines Patch % Lines
testnet/stacks-node/src/tests/signer/v0.rs 47.25% 240 Missing ⚠️
stacks-signer/src/v0/signer_state.rs 74.88% 57 Missing ⚠️
stacks-signer/src/chainstate/v2.rs 61.70% 54 Missing ⚠️
stacks-signer/src/v0/signer.rs 49.45% 46 Missing ⚠️
stacks-signer/src/signerdb.rs 77.27% 35 Missing ⚠️
libsigner/src/v0/messages.rs 77.04% 28 Missing ⚠️
stacks-signer/src/chainstate/mod.rs 90.56% 25 Missing ⚠️
stacks-signer/src/chainstate/v1.rs 94.38% 15 Missing ⚠️
libsigner/src/v0/signer_state.rs 86.20% 8 Missing ⚠️
...tacks-node/src/tests/signer/commands/block_wait.rs 0.00% 4 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6215      +/-   ##
===========================================
+ Coverage    81.96%   82.14%   +0.18%     
===========================================
  Files          543      546       +3     
  Lines       345677   347228    +1551     
  Branches       323      323              
===========================================
+ Hits        283332   285230    +1898     
+ Misses       62337    61990     -347     
  Partials         8        8              
Files with missing lines Coverage Δ
stacks-signer/src/chainstate/tests/v1.rs 100.00% <100.00%> (ø)
stacks-signer/src/chainstate/tests/v2.rs 100.00% <100.00%> (ø)
stacks-signer/src/client/mod.rs 99.24% <100.00%> (+<0.01%) ⬆️
stacks-signer/src/config.rs 91.24% <100.00%> (+0.36%) ⬆️
stacks-signer/src/lib.rs 90.00% <ø> (ø)
stacks-signer/src/runloop.rs 89.70% <100.00%> (+0.04%) ⬆️
stacks-signer/src/v0/tests.rs 87.05% <100.00%> (+10.58%) ⬆️
testnet/stacks-node/src/nakamoto_node/miner.rs 81.46% <100.00%> (-2.01%) ⬇️
...net/stacks-node/src/tests/nakamoto_integrations.rs 87.01% <100.00%> (+1.00%) ⬆️
...stacks-node/src/tests/signer/commands/sortition.rs 81.48% <100.00%> (ø)
... and 13 more

... and 50 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4980dd...34eb466. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jferrant jferrant requested review from hstove, kantai and obycode June 23, 2025 16:30
@jferrant jferrant added this to the 3.1.0.0.13 milestone Jun 23, 2025
@jferrant jferrant force-pushed the feat/signer-state-machine-rollout branch from 35ad183 to ea69d33 Compare June 23, 2025 19:22
@kantai kantai moved this to Status: 💻 In Progress in Stacks Core Eng Jun 24, 2025
@jferrant jferrant force-pushed the feat/signer-state-machine-rollout branch from 6fd42cb to 4d199ef Compare June 25, 2025 01:37
Copy link
Contributor

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits, but otherwise LGTM!

…igner-v3-1-0-0-13 feature

Signed-off-by: Jacinta Ferrant <[email protected]>
hstove
hstove previously approved these changes Jul 9, 2025
obycode
obycode previously approved these changes Jul 9, 2025
@jferrant jferrant dismissed stale reviews from obycode and hstove via 30816d6 July 9, 2025 20:19
kantai
kantai previously approved these changes Jul 9, 2025
@jferrant jferrant requested review from hstove and obycode July 9, 2025 20:23
obycode
obycode previously approved these changes Jul 9, 2025
@jferrant jferrant enabled auto-merge July 9, 2025 20:27
@jferrant jferrant added this pull request to the merge queue Jul 9, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jul 9, 2025
@jferrant jferrant dismissed stale reviews from obycode and kantai via 34eb466 July 10, 2025 02:11
@aldur aldur added this pull request to the merge queue Jul 10, 2025
Merged via the queue into stacks-network:develop with commit c86013a Jul 10, 2025
237 of 240 checks passed
@github-project-automation github-project-automation bot moved this from Status: 💻 In Progress to Status: ✅ Done in Stacks Core Eng Jul 10, 2025
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants