Chore/extract chainstate from peer

[jferrant]

This builds upon #6531 which should get merged first. It might be a worthwhile effort to simplify a lot of our tests that utilize TestPeer to use TestChainstate directly (i.e. a lot of them don't even rely on the mempool/Relayer threads etc.) but I would only do this as a follow on and more piece meal.

[codecov]

Codecov Report

❌ Patch coverage is 84.05421% with 553 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.94%. Comparing base (962e7dd) to head (8531746).

Files with missing lines	Patch %	Lines
stackslib/src/chainstate/tests/mod.rs	79.85%	217 Missing ⚠️
stackslib/src/net/tests/relay/epoch2x.rs	34.42%	120 Missing ⚠️
stackslib/src/chainstate/tests/consensus.rs	71.72%	69 Missing ⚠️
stackslib/src/net/tests/download/epoch2x.rs	22.85%	54 Missing ⚠️
stackslib/src/net/mod.rs	79.90%	43 Missing ⚠️
stackslib/src/net/tests/inv/epoch2x.rs	74.13%	15 Missing ⚠️
stackslib/src/chainstate/nakamoto/tests/node.rs	87.75%	12 Missing ⚠️
stackslib/src/net/api/tests/postblock_proposal.rs	65.38%	9 Missing ⚠️
...tackslib/src/chainstate/stacks/boot/pox_2_tests.rs	93.10%	6 Missing ⚠️
stackslib/src/net/tests/mod.rs	96.46%	4 Missing ⚠️
... and 2 more

Additional details and impacted files

@@                   Coverage Diff                   @@
##           aac-client-breaking    #6536      +/-   ##
=======================================================
+ Coverage                75.06%   79.94%   +4.88%     
=======================================================
  Files                      566      568       +2     
  Lines                   345526   346578    +1052     
=======================================================
+ Hits                    259370   277084   +17714     
+ Misses                   86156    69494   -16662     

Files with missing lines	Coverage Δ
...kslib/src/chainstate/nakamoto/coordinator/tests.rs	99.65% <100.00%> (+5.06%)	⬆️
stackslib/src/chainstate/nakamoto/tests/mod.rs	99.12% <100.00%> (+11.84%)	⬆️
stackslib/src/chainstate/stacks/boot/mod.rs	94.17% <100.00%> (+6.17%)	⬆️
...tackslib/src/chainstate/stacks/boot/pox_3_tests.rs	98.41% <100.00%> (+14.28%)	⬆️
stackslib/src/chainstate/stacks/db/blocks.rs	88.39% <100.00%> (+3.42%)	⬆️
stackslib/src/chainstate/stacks/db/unconfirmed.rs	93.17% <100.00%> (+0.42%)	⬆️
...tackslib/src/chainstate/stacks/tests/accounting.rs	99.68% <100.00%> (+1.25%)	⬆️
.../src/chainstate/stacks/tests/block_construction.rs	97.61% <100.00%> (+17.41%)	⬆️
stackslib/src/clarity_vm/tests/ephemeral.rs	93.98% <100.00%> (ø)
stackslib/src/net/api/tests/blockreplay.rs	93.47% <100.00%> (ø)
... and 23 more

... and 224 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 962e7dd...8531746. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jferrant]

Replaced by #6557

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.