AAC Testing: Runtime CheckErrorKind batch number 1

[jacinta-stacks]

Note i was able to remove InvalidSecp65k1Signature. (It is never actually ever returned/used. Its just mapped from a diff Error to the intermediary type to immediately get remapped again to a ParseError)

Really really struggled this time around even more than the other runtime error types to be confident in my assessement of the unreachable ones. :/

[codecov]

Codecov Report

❌ Patch coverage is 1.59236% with 309 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.82%. Comparing base (1d7f6d7) to head (61db3bb).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines	Patch %	Lines
...lib/src/chainstate/tests/runtime_analysis_tests.rs	0.00%	224 Missing ⚠️
clarity/src/vm/tests/post_conditions.rs	0.00%	61 Missing ⚠️
clarity-types/src/tests/types/mod.rs	0.00%	18 Missing ⚠️
clarity/src/vm/tests/sequences.rs	0.00%	5 Missing ⚠️
clarity/src/vm/functions/crypto.rs	83.33%	1 Missing ⚠️

❌ Your project check has failed because the head coverage (26.82%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (1d7f6d7) and HEAD (61db3bb). Click for more details.

HEAD has 9 uploads less than BASE

Flag	BASE (1d7f6d7)	HEAD (61db3bb)
	52	43

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #6717       +/-   ##
============================================
- Coverage    72.52%   26.82%   -45.71%     
============================================
  Files          578      578               
  Lines       358781   359080      +299     
============================================
- Hits        260215    96330   -163885     
- Misses       98566   262750   +164184     

Files with missing lines	Coverage Δ
clarity-types/src/errors/analysis.rs	18.06% <ø> (-62.00%)	⬇️
clarity-types/src/types/mod.rs	43.77% <ø> (-51.08%)	⬇️
clarity/src/vm/contexts.rs	50.15% <ø> (-41.30%)	⬇️
clarity/src/vm/functions/define.rs	74.06% <ø> (-24.82%)	⬇️
clarity/src/vm/functions/mod.rs	52.53% <ø> (-44.68%)	⬇️
clarity/src/vm/functions/post_conditions.rs	51.38% <ø> (-36.62%)	⬇️
clarity/src/vm/functions/crypto.rs	13.04% <83.33%> (-64.91%)	⬇️
clarity/src/vm/tests/sequences.rs	0.00% <0.00%> (-89.38%)	⬇️
clarity-types/src/tests/types/mod.rs	0.00% <0.00%> (-83.98%)	⬇️
clarity/src/vm/tests/post_conditions.rs	0.00% <0.00%> (-85.80%)	⬇️
... and 1 more

... and 501 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d7f6d7...61db3bb. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jacinta-stacks]

I apologise in advance @federico-stacks . I am going to force push to fix my signature!

[Jiloc]

I am still digging into some of the other uneachable variants

[francesco-stacks]

I am still digging into some of the others uneachable variants

[francesco-stacks]

I went over all errors marked as unreachable, and I wasn't able to trigger anything else! I just left a note about one that's actually reachable, but never returned directly

[francesco-stacks]

lgtm!