Skip to content

Conversation

@hstove-stacks
Copy link

I was bothered by my IDE warning me about this use of "unsafe" code, so I went to refactor it. Turns out this ENV var just isn't used, so it can be removed.

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.87%. Comparing base (7ff75a2) to head (1030ca1).
⚠️ Report is 10 commits behind head on develop.

❌ Your project status has failed because the head coverage (70.87%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6734      +/-   ##
===========================================
+ Coverage    70.05%   70.87%   +0.81%     
===========================================
  Files          578      578              
  Lines       358373   358370       -3     
===========================================
+ Hits        251064   253987    +2923     
+ Misses      107309   104383    -2926     
Files with missing lines Coverage Δ
stacks-node/src/tests/signer/v0.rs 49.59% <ø> (+19.71%) ⬆️

... and 386 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ff75a2...1030ca1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@francesco-stacks francesco-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just double checked that it wasn't used anywhere in the code

@federico-stacks federico-stacks self-requested a review December 3, 2025 15:24
@hstove-stacks hstove-stacks added this pull request to the merge queue Dec 3, 2025
Merged via the queue into stacks-network:develop with commit 1d7f6d7 Dec 3, 2025
619 of 622 checks passed
@hstove-stacks hstove-stacks deleted the fix/remove-unsafe-set-var branch December 3, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants