Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove netcdf from whoi items #37

Merged
merged 4 commits into from
Oct 31, 2022
Merged

Remove netcdf from whoi items #37

merged 4 commits into from
Oct 31, 2022

Conversation

gadomski
Copy link
Contributor

@gadomski gadomski commented Oct 31, 2022

Description:
Because those NetCDFs represent a larger time period than the item represents, it doesn't make sense to keep the NetCDFs as assets on the items. The NetCDFs belong on their own items, maybe in their own collection.

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Examples have been updated to reflect changes, if applicable
  • Changes are added to the CHANGELOG.

@gadomski gadomski merged commit 7e30bcf into main Oct 31, 2022
@gadomski gadomski deleted the remove-netcdf-whoi branch October 31, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant