Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add time intervals #46

Merged
merged 4 commits into from
Mar 8, 2023
Merged

Add time intervals #46

merged 4 commits into from
Mar 8, 2023

Conversation

gadomski
Copy link
Contributor

@gadomski gadomski commented Mar 7, 2023 •
edited
Loading

Related Issue(s):

Description:
This adds time intervals to all NetCDFs that might have them, and to all ocean heat content cogs. It doesn't:

  • Add intervals to other CDR types (I'll come back and add them later if I think they're appropriate)
  • Check to make sure we've captured all necessary TimeResolution values (we'll wait for this to error in the test instance and then add back as needed)

Also switches to importlib_resources to silence some warnings.

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Examples have been updated to reflect changes, if applicable
  • Changes are added to the CHANGELOG.

@gadomski gadomski self-assigned this Mar 7, 2023
@gadomski gadomski merged commit 3c84593 into main Mar 8, 2023
@gadomski gadomski deleted the issues/45-ocean-heat-content-time-interval branch March 8, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add attribute for time period for ocean heat content
1 participant
@gadomski