Skip to content

add std:: in tests to avoid ambiguity #3080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Conversation

rok-cesnovar
Copy link
Member

Adds namespace qualifiers in a couple of spots. After stan-dev/math#2612, Stan Math will have overloads for all primitive scalar argument types and we need to avoid ambiguity in a couple of places.

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Rok Češnovar

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@rok-cesnovar
Copy link
Member Author

@WardBrian Would you have time to review this one? Seems to be the last barrier for #2612

@stan-buildbot
Copy link
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 3.56 3.63 0.98 -2.05% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 1.0 -0.21% slower
eight_schools/eight_schools.stan 0.09 0.09 1.05 4.42% faster
gp_regr/gp_regr.stan 0.14 0.15 0.98 -2.42% slower
irt_2pl/irt_2pl.stan 5.83 5.87 0.99 -0.68% slower
performance.compilation 93.27 90.84 1.03 2.61% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 8.27 8.11 1.02 1.89% faster
pkpd/one_comp_mm_elim_abs.stan 31.18 30.43 1.02 2.4% faster
sir/sir.stan 118.52 117.34 1.01 1.0% faster
gp_regr/gen_gp_data.stan 0.03 0.03 0.95 -5.21% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.02 2.97 1.02 1.72% faster
pkpd/sim_one_comp_mm_elim_abs.stan 0.37 0.41 0.91 -9.31% slower
arK/arK.stan 2.79 2.78 1.0 0.22% faster
arma/arma.stan 0.25 0.25 1.0 0.36% faster
garch/garch.stan 0.72 0.72 0.99 -0.57% slower
Mean result: 0.997165016233

Jenkins Console Log
Blue Ocean
Commit hash: a77b216


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Copy link
Member

@WardBrian WardBrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is there any merit in adding these changes to the other PR to make sure they resolve the test issues there?

@rok-cesnovar rok-cesnovar merged commit 233d9bf into develop Nov 9, 2021
@rok-cesnovar rok-cesnovar deleted the add_namespace_to_pow branch November 9, 2021 14:33
@rok-cesnovar
Copy link
Member Author

Do you mean for stan-dev/math#2612?

Merging this will resolve the test issues there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants