Skip to content

fix: correct ACCEPT_LISCENSE typo to ACCEPT_LICENSE in Gentoo make.conf#45

Merged
stanfish06 merged 2 commits into
masterfrom
copilot/weekly-repo-review-2026-w19
May 4, 2026
Merged

fix: correct ACCEPT_LISCENSE typo to ACCEPT_LICENSE in Gentoo make.conf#45
stanfish06 merged 2 commits into
masterfrom
copilot/weekly-repo-review-2026-w19

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 4, 2026

ACCEPT_LISCENSE in gentoo/configs-TF-X220/etc-TF-X220/portage/make.conf is a misspelling — Portage silently ignores unknown variables, so @BINARY-REDISTRIBUTABLE was never applied, blocking binary packages like linux-firmware without explicit per-package license overrides.

Changes

  • gentoo/configs-TF-X220/etc-TF-X220/portage/make.conf: rename ACCEPT_LISCENSEACCEPT_LICENSE
-ACCEPT_LISCENSE="@FREE @BINARY-REDISTRIBUTABLE"
+ACCEPT_LICENSE="@FREE @BINARY-REDISTRIBUTABLE"

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/graphql
    • Triggering command: /usr/bin/gh gh auth status (http block)
    • Triggering command: /usr/bin/gh gh issue create --title gentoo i3 config: hardcoded wallpaper path ~/Git/my-configs/img/raccoon.jpg --body **File:** gentoo/configs-TF-X220/home-stan/dot-config/i3/config`
      Line 38:
exec --no-startup-id feh --bg-scale ~/Git/my-configs/img/raccoon.jpg

The wallpaper path is hardcoded to ~/Git/my-configs/img/raccoon.jpg, which assumes the repo is a` (http block)

  • https://api.github.com/repos/stanfish06/my-configs/issues
    • Triggering command: /usr/bin/curl curl -sS -X POST -H Authorization: ****** -H Accept: application/vnd.github+json -H X-GitHub-Api-Version: 2022-11-28 REDACTED --data @/tmp/i3-issue.json (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI linked an issue May 4, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Review commits and PRs for week 19 of 2026 fix: correct ACCEPT_LISCENSE typo to ACCEPT_LICENSE in Gentoo make.conf May 4, 2026
Copilot AI requested a review from stanfish06 May 4, 2026 16:18
@stanfish06 stanfish06 marked this pull request as ready for review May 4, 2026 16:26
@stanfish06 stanfish06 merged commit 157715e into master May 4, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Weekly repo review – 2026-W19

2 participants