fix: redact remaining personal identifiers in hpc, wezterm, sway, and email.service#81
fix: redact remaining personal identifiers in hpc, wezterm, sway, and email.service#81stanfish06 wants to merge 1 commit into
Conversation
… and email.service - hpc/monitor_job.sh: squeue -u zyyu → squeue -u "$USER" (issue #77) - wezterm/.wezterm.lua: username "zyyu" → "username" in ssh_domains and launch_menu (issue #77); background image path C:/Users/zhiyu/... → wezterm.home_dir .. "/.config/wezterm/background.jpg" (issue #80) - sway/40-sway-background.conf: /home/stanfish/Git/... → ~/.config/sway/wallpaper.jpeg (issue #78, same symlink pattern as PR #47 for i3) - linux/services/email.service: User=stanfish → placeholder comment, ExecStart=/home/stanfish/... → %h/... systemd specifier (issue #78) Wire up sway wallpaper once at deploy time: ln -sf ~/Git/my-configs/img/space.jpeg ~/.config/sway/wallpaper.jpeg Wire up wezterm background once at deploy time: ln -sf ~/Git/my-configs/img/dark-green-forest.jpg ~/.config/wezterm/background.jpg Closes #77 Closes #78 Closes #80
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d83fdc864
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # User= # set locally: User=your-username | ||
| ExecStart=%h/scripts/system/fetch-emails.sh |
There was a problem hiding this comment.
Restore explicit User= for email service
Removing User= from this system unit makes the service run as root by default and changes %h in ExecStart to root’s home, so it tries to execute /root/scripts/system/fetch-emails.sh instead of the intended unprivileged user script path. In this repo state, systemd-analyze verify linux/services/email.service already resolves the command to /root/... and reports it missing, so the service fails unless each machine patches the unit locally and otherwise runs with elevated privileges.
Useful? React with 👍 / 👎.
| name = "greatlakes", | ||
| remote_address = "greatlakes.arc-ts.umich.edu", | ||
| username = "zyyu", | ||
| username = "username", |
There was a problem hiding this comment.
Avoid hard-coding placeholder SSH username
Setting the SSH user to the literal string "username" breaks the WezTerm Great Lakes shortcut for any account that is not actually named username; both ssh_domains and the launch menu now target the wrong remote user and will fail authentication in normal setups. This redaction should use a dynamic value (or omit the user so SSH picks the local default) rather than a fixed placeholder.
Useful? React with 👍 / 👎.
| User=stanfish | ||
| ExecStart=/home/stanfish/scripts/system/fetch-emails.sh | ||
| # User= # set locally: User=your-username | ||
| ExecStart=%h/scripts/system/fetch-emails.sh |
There was a problem hiding this comment.
Stop using %h in this system unit ExecStart
%h in a system service does not follow the runtime User= expectation here and resolves to the system manager’s home (/root), so even after following the inline comment and setting User=your-username, ExecStart=%h/scripts/system/fetch-emails.sh still points at /root/scripts/... and won’t run the intended per-user script. A local repro with systemd-analyze verify on a test unit with User=nobody resolves %h to /root, confirming this path strategy is incorrect for this unit type.
Useful? React with 👍 / 👎.
Closes #77
Closes #78
Closes #80
PR #79 was closed without merging. Issues #77 and #78 remain open. This PR re-applies those fixes and also addresses the newly-found #80 (wezterm background path).
Changes
1.
hpc/monitor_job.sh— use$USERinstead ofzyyu(issue #77)2.
wezterm/.wezterm.lua— three redactionsissue #77 — HPC username in ssh_domains and launch_menu:
issue #80 — personal Windows username
zhiyuin background image path:Wire up at deploy time:
3.
sway/40-sway-background.conf— stable wallpaper path (issue #78)Wire up at deploy time:
4.
linux/services/email.service— use%hspecifier (issue #78)Test plan
grep -r 'zyyu\|zyu14' hpc/monitor_job.sh wezterm/— no matchesgrep -r 'zhiyu\|Users/' wezterm/— no matchesgrep -r 'home/stanfish' sway/ linux/services/— no matchesmonitor_job.shon HPC lists current user's jobs~/.config/sway/wallpaper.jpeg~/.config/wezterm/background.jpgGenerated by Claude Code