production-grade improvements: workflows, tests, benchmarks, docs#8
Open
AbdelStark wants to merge 2 commits intomainfrom
Open
production-grade improvements: workflows, tests, benchmarks, docs#8AbdelStark wants to merge 2 commits intomainfrom
AbdelStark wants to merge 2 commits intomainfrom
Conversation
Collaborator
AbdelStark
commented
Dec 21, 2025
AbdelStark
commented
- Add comprehensive GitHub workflows (CI, security, benchmarks, release)
- Create detailed DESIGN.md documenting hash function architecture
- Implement comprehensive test suite:
- Integration tests for complete hash behavior
- Property-based tests with proptest
- Enhanced avalanche analysis (SAC, BIC, diffusion)
- Test vector validation
- Add production-grade benchmarks with Criterion
- Add supporting documentation (SECURITY.md, CONTRIBUTING.md)
- Polish code with rustfmt.toml, clippy.toml, .editorconfig
- Update README with technical accuracy and Bitcoin focus
- Add deny.toml for license/dependency auditing
- Add comprehensive GitHub workflows (CI, security, benchmarks, release) - Create detailed DESIGN.md documenting hash function architecture - Implement comprehensive test suite: - Integration tests for complete hash behavior - Property-based tests with proptest - Enhanced avalanche analysis (SAC, BIC, diffusion) - Test vector validation - Add production-grade benchmarks with Criterion - Add supporting documentation (SECURITY.md, CONTRIBUTING.md) - Polish code with rustfmt.toml, clippy.toml, .editorconfig - Update README with technical accuracy and Bitcoin focus - Add deny.toml for license/dependency auditing
- Update test vectors in basic_test_vector.json, vectors.rs, README.md, and DESIGN.md to match v2 algorithm outputs - Fix clippy warnings (needless_range_loop, same_item_push, etc.) - Adjust avalanche test thresholds for SIMPLE variant - Fix formatting issues in comprehensive.rs - All 109 tests now pass, clippy clean, format check passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.