Skip to content

Conversation

@giladchase
Copy link
Contributor

Note: change in attribute_errors are since & can now also be Unary, and the
test wanted to test a missing binary operator, so / is now the binary operator used to keep
the spirit of the test without changing the diff.

@reviewable-StarkWare
Copy link

This change is Reviewable

@giladchase giladchase marked this pull request as ready for review October 27, 2025 13:26
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orizi reviewed 7 of 10 files at r1, all commit messages.
Reviewable status: 7 of 10 files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)


crates/cairo-lang-semantic/src/corelib.rs line 555 at r1 (raw file):

        UnaryOperator::At(_) => unreachable!("@ is not an unary operator."),
        UnaryOperator::Desnap(_) => unreachable!("* is not an unary operator."),
        UnaryOperator::Reference(_) => todo!(),

unreachable as well.

Code quote:

        UnaryOperator::Reference(_) => todo!(),

Note: change in `attribute_errors` are since `&` can now also be Unary, and the
test wanted to test a missing binary operator, so `/` is now the binary operator used to keep
the spirit of the test without changing the diff.
@giladchase giladchase force-pushed the gilad/10-26-feat_add_t_to_parser_semantic_not_implemented_yet branch from fe72798 to 57a9131 Compare October 28, 2025 06:04
Copy link
Contributor Author

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 6 of 10 files reviewed, 1 unresolved discussion (waiting on @orizi and @TomerStarkware)


crates/cairo-lang-semantic/src/corelib.rs line 555 at r1 (raw file):

Previously, orizi wrote…

unreachable as well.

Done, though what i wrote in the unreachable string will be relevant from the next PR once we add the code that handles it into compute.rs.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@orizi reviewed 3 of 10 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

@giladchase giladchase added this pull request to the merge queue Oct 28, 2025
Merged via the queue into main with commit 26e3db1 Oct 28, 2025
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants