Skip to content

blockifier: log state diff on concurrency validation failure #9870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main-v0.14.1
Choose a base branch
from
Open

blockifier: log state diff on concurrency validation failure #9870

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions crates/blockifier/src/concurrency/worker_logic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,18 @@ impl<S: StateReader> WorkerExecutor<S> {
let reads = &execution_output.reads;
let reads_valid = tx_versioned_state.validate_reads(reads)?;

if !reads_valid {
let tx = self.tx_at(tx_index);
let tx_hash = Transaction::tx_hash(tx.as_ref());
log::debug!(
"Validation failed for tx {} ({}): stale reads detected, discarding speculative \
state_diff: {:?}",
tx_index,
tx_hash,
execution_output.state_diff
);
}

let aborted = !reads_valid && self.scheduler.try_validation_abort(tx_index, commit_phase);
if aborted {
self.metrics.count_abort();
Expand Down
Loading