-
Notifications
You must be signed in to change notification settings - Fork 64
starknet_os: migrate test_revert #9883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
starknet_os: migrate test_revert #9883
Conversation
5323469 to
047488e
Compare
01390ab to
3846361
Compare
047488e to
308d88f
Compare
4487af6 to
0adbc6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yoni-Starkware reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/starknet_os/src/hints/hint_implementation/cairo1_revert/test.rs line 82 at r1 (raw file):
map.insert(*address, *value); }) .or_insert_with(|| HashMap::from([(*address, *value)]));
Suggestion:
.entry(current_contract_address).or_default().insert(*address, *value);0adbc6f to
295bdd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)
crates/starknet_os/src/hints/hint_implementation/cairo1_revert/test.rs line 82 at r1 (raw file):
map.insert(*address, *value); }) .or_insert_with(|| HashMap::from([(*address, *value)]));
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yoni-Starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
295bdd6 to
ba674ca
Compare
308d88f to
5b6c74c
Compare
Merge activity
|

No description provided.