Skip to content

Conversation

@dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@dorimedini-starkware dorimedini-starkware self-assigned this Oct 30, 2025
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review October 30, 2025 16:45
@dorimedini-starkware dorimedini-starkware force-pushed the 10-28-starknet_os_move_cairo1_revert_module_into_separate_folder branch from 5323469 to 047488e Compare October 30, 2025 16:49
@dorimedini-starkware dorimedini-starkware force-pushed the 10-30-starknet_os_migrate_test_revert branch from 01390ab to 3846361 Compare October 30, 2025 16:49
@dorimedini-starkware dorimedini-starkware force-pushed the 10-28-starknet_os_move_cairo1_revert_module_into_separate_folder branch from 047488e to 308d88f Compare October 30, 2025 17:25
@dorimedini-starkware dorimedini-starkware force-pushed the 10-30-starknet_os_migrate_test_revert branch 2 times, most recently from 4487af6 to 0adbc6f Compare October 30, 2025 17:38
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


crates/starknet_os/src/hints/hint_implementation/cairo1_revert/test.rs line 82 at r1 (raw file):

                        map.insert(*address, *value);
                    })
                    .or_insert_with(|| HashMap::from([(*address, *value)]));

Suggestion:

                    .entry(current_contract_address).or_default().insert(*address, *value);

@dorimedini-starkware dorimedini-starkware force-pushed the 10-30-starknet_os_migrate_test_revert branch from 0adbc6f to 295bdd6 Compare November 2, 2025 13:47
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)


crates/starknet_os/src/hints/hint_implementation/cairo1_revert/test.rs line 82 at r1 (raw file):

                        map.insert(*address, *value);
                    })
                    .or_insert_with(|| HashMap::from([(*address, *value)]));

Done.

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@graphite-app graphite-app bot changed the base branch from 10-28-starknet_os_move_cairo1_revert_module_into_separate_folder to graphite-base/9883 November 2, 2025 14:10
@dorimedini-starkware dorimedini-starkware force-pushed the 10-30-starknet_os_migrate_test_revert branch from 295bdd6 to ba674ca Compare November 2, 2025 14:27
@graphite-app graphite-app bot changed the base branch from graphite-base/9883 to main November 2, 2025 14:28
@graphite-app
Copy link

graphite-app bot commented Nov 2, 2025

Merge activity

  • Nov 2, 2:28 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Nov 2, 2025
Merged via the queue into main with commit c5469d1 Nov 2, 2025
17 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants