-
Notifications
You must be signed in to change notification settings - Fork 65
apollo_l1_provider: add flow test for cancellation #9915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apollo_l1_provider: add flow test for cancellation #9915
Conversation
edcf3af to
af6c594
Compare
d77bea3 to
318a4c8
Compare
|
Rename this file to utils (unless common is a special word in rust that says don't run this as a test) |
ShahakShama
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShahakShama reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @guy-starkware)
crates/apollo_l1_provider/tests/flow_test_consumed.rs line 15 at r2 (raw file):
#[tokio::test] async fn l1_handler_tx_consumed_timelock() {
This looks like a duplicate of the test below it
af6c594 to
b49fff1
Compare
318a4c8 to
0630076
Compare
b49fff1 to
8a4a6ed
Compare
0630076 to
337a708
Compare
ShahakShama
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShahakShama reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guy-starkware)
guy-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)
crates/apollo_l1_provider/tests/flow_test_consumed.rs line 15 at r2 (raw file):
Previously, ShahakShama wrote…
This looks like a duplicate of the test below it
you are right. This was added by mistake from a different branch.
ShahakShama
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)
337a708 to
3719329
Compare
8a4a6ed to
4288eec
Compare
dce5495 to
8d5c883
Compare
4288eec to
4f2f087
Compare
ShahakShama
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShahakShama reviewed 7 of 7 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)
8d5c883 to
5e829ca
Compare
27244bb to
ee32f5d
Compare
5e829ca to
b3096fe
Compare
ee32f5d to
047d58c
Compare
b3096fe to
434c673
Compare
434c673 to
49e763c
Compare
047d58c to
e8c805c
Compare
Merge activity
|
49e763c to
d34548e
Compare
guy-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guy-starkware reviewed 1 of 3 files at r3, 5 of 7 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)
d34548e to
e48c78c
Compare
guy-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guy-starkware reviewed 2 of 2 files at r6, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)
e48c78c to
b80dbb2
Compare
b80dbb2 to
aa4aa63
Compare
guy-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guy-starkware reviewed 2 of 2 files at r7, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

No description provided.