Skip to content

Conversation

@guy-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@ShahakShama
Copy link
Collaborator

crates/apollo_l1_provider/tests/common/mod.rs line 1 at r2 (raw file):

use std::sync::Arc;

Rename this file to utils (unless common is a special word in rust that says don't run this as a test)

Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @guy-starkware)


crates/apollo_l1_provider/tests/flow_test_consumed.rs line 15 at r2 (raw file):

#[tokio::test]
async fn l1_handler_tx_consumed_timelock() {

This looks like a duplicate of the test below it

@guy-starkware guy-starkware force-pushed the guyn/l1provider/flow_test_setup_function branch from af6c594 to b49fff1 Compare November 4, 2025 09:45
@guy-starkware guy-starkware force-pushed the guyn/l1provider/flow_test_cancellation branch from 318a4c8 to 0630076 Compare November 4, 2025 09:45
@guy-starkware guy-starkware force-pushed the guyn/l1provider/flow_test_setup_function branch from b49fff1 to 8a4a6ed Compare November 4, 2025 10:02
@guy-starkware guy-starkware force-pushed the guyn/l1provider/flow_test_cancellation branch from 0630076 to 337a708 Compare November 4, 2025 10:02
Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guy-starkware)

Copy link
Contributor Author

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)


crates/apollo_l1_provider/tests/flow_test_consumed.rs line 15 at r2 (raw file):

Previously, ShahakShama wrote…

This looks like a duplicate of the test below it

you are right. This was added by mistake from a different branch.

Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

@guy-starkware guy-starkware force-pushed the guyn/l1provider/flow_test_cancellation branch from 337a708 to 3719329 Compare November 4, 2025 13:08
@guy-starkware guy-starkware force-pushed the guyn/l1provider/flow_test_setup_function branch from 8a4a6ed to 4288eec Compare November 4, 2025 13:15
@guy-starkware guy-starkware force-pushed the guyn/l1provider/flow_test_cancellation branch 2 times, most recently from dce5495 to 8d5c883 Compare November 4, 2025 14:23
@guy-starkware guy-starkware force-pushed the guyn/l1provider/flow_test_setup_function branch from 4288eec to 4f2f087 Compare November 4, 2025 14:23
Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama reviewed 7 of 7 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

@guy-starkware guy-starkware force-pushed the guyn/l1provider/flow_test_cancellation branch from 8d5c883 to 5e829ca Compare November 6, 2025 08:07
@guy-starkware guy-starkware force-pushed the guyn/l1provider/flow_test_setup_function branch 2 times, most recently from 27244bb to ee32f5d Compare November 9, 2025 13:01
@guy-starkware guy-starkware force-pushed the guyn/l1provider/flow_test_cancellation branch from 5e829ca to b3096fe Compare November 9, 2025 13:01
@guy-starkware guy-starkware force-pushed the guyn/l1provider/flow_test_setup_function branch from ee32f5d to 047d58c Compare November 9, 2025 13:42
@guy-starkware guy-starkware force-pushed the guyn/l1provider/flow_test_cancellation branch from b3096fe to 434c673 Compare November 9, 2025 13:42
@graphite-app graphite-app bot changed the base branch from guyn/l1provider/flow_test_setup_function to graphite-base/9915 November 11, 2025 09:16
@guy-starkware guy-starkware force-pushed the guyn/l1provider/flow_test_cancellation branch from 434c673 to 49e763c Compare November 11, 2025 09:46
@graphite-app graphite-app bot changed the base branch from graphite-base/9915 to main-v0.14.1 November 11, 2025 09:46
@graphite-app
Copy link

graphite-app bot commented Nov 11, 2025

Merge activity

  • Nov 11, 9:46 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@guy-starkware guy-starkware force-pushed the guyn/l1provider/flow_test_cancellation branch from 49e763c to d34548e Compare November 11, 2025 09:49
Copy link
Contributor Author

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guy-starkware reviewed 1 of 3 files at r3, 5 of 7 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

@guy-starkware guy-starkware force-pushed the guyn/l1provider/flow_test_cancellation branch from d34548e to e48c78c Compare November 11, 2025 10:16
Copy link
Contributor Author

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guy-starkware reviewed 2 of 2 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

@guy-starkware guy-starkware force-pushed the guyn/l1provider/flow_test_cancellation branch from e48c78c to b80dbb2 Compare November 11, 2025 11:20
@guy-starkware guy-starkware force-pushed the guyn/l1provider/flow_test_cancellation branch from b80dbb2 to aa4aa63 Compare November 11, 2025 11:24
Copy link
Contributor Author

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guy-starkware reviewed 2 of 2 files at r7, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

@guy-starkware guy-starkware added this pull request to the merge queue Nov 11, 2025
Merged via the queue into main-v0.14.1 with commit 77082f1 Nov 11, 2025
16 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants