test: add update_rewards toggle tokens flow test

[arad-starkware]

This change is 

---

Note

Adds a comprehensive flow test validating staker/delegator rewards when toggling BTC tokens across attestation and consensus epochs, plus trims related flow ideas.

• Tests:
  • update_rewards_token_enable_disable_flow_test in src/flow_test/test.cairo:
    • Sets up two BTC tokens with different decimals; delegates to both.
    • Toggles enable/disable states across epochs and transitions from attestation to consensus.
    • Verifies staker commission and delegator rewards per token, including multiple update_rewards calls in the same epoch and normalized balance calculations.
• Docs:
  • Streamlines flow idea under k=1 -> k=2 token in src/flow_test/flow_ideas.md.

^{Written by Cursor Bugbot for commit 0b18f21. This will update automatically on new commits. Configure here.}

[arad-starkware]

• test: add accrue_rewards_across_versions flow #82 : 2 dependent PRs (#83 , #84 )
• test: add attest after upgrade test #71
• test: add token state after upgrade flow #59
• test: add update_rewards toggle tokens flow test #57 👈 (View in Graphite)
• test: add balances delay flow #65
• chore: update flow ideas #61
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.78%. Comparing base (53bea2b) to head (0b18f21).

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   95.74%   95.78%   +0.03%     
==========================================
  Files          42       42              
  Lines       10041    10133      +92     
==========================================
+ Hits         9614     9706      +92     
  Misses        427      427              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[noa-starkware]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @arad-starkware)

---

src/flow_test/test.cairo line 3039 at r3 (raw file):

/// Advance K epochs
/// Enable token A, disable token B
/// update_rewards

I think we need this test for both v2 rewards and consensus rewards, please update the test

---

src/flow_test/flows.cairo line 7070 at r3 (raw file):

/// Add tokens A and B
/// Enable token B
/// Advance epoch

rebase issues?

[arad-starkware]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @noa-starkware)

---

src/flow_test/test.cairo line 3039 at r3 (raw file):

Previously, noa-starkware wrote…

I think we need this test for both v2 rewards and consensus rewards, please update the test

I'm not sure about the flow you're describing, do you mean specifically v2 rewards and consensus in the same test? we have MultipleTokensDelegationFlow for v2 rewards otherwise

---

src/flow_test/flows.cairo line 7070 at r3 (raw file):

Previously, noa-starkware wrote…

rebase issues?

yes

[noa-starkware]

Reviewable status: 0 of 3 files reviewed, 7 unresolved discussions (waiting on @arad-starkware)

---

src/flow_test/test.cairo line 3094 at r6 (raw file):

    // update_rewards - test rewards only for token B
    system.advance_block_into_attestation_window(:staker);
    system.attest(:staker);

test also staker rewards please

---

src/flow_test/test.cairo line 3111 at r6 (raw file):

    // update_rewards - test rewards only for token B
    system.advance_block_into_attestation_window(:staker);
    system.attest(:staker);

test also staker rewards please

---

src/flow_test/test.cairo line 3120 at r6 (raw file):

    // update_rewards - test rewards only for token A
    system.advance_block_into_attestation_window(:staker);
    system.attest(:staker);

test also staker rewards please

---

src/flow_test/test.cairo line 3128 at r6 (raw file):

    // Start consensus rewards
    system.start_consensus_rewards();

// Enable token B, disable token A

---

src/flow_test/test.cairo line 3148 at r6 (raw file):

    // update_rewards - test rewards only for token A
    system.update_rewards(:staker, disable_rewards: false);

test also staker rewards please

---

src/flow_test/test.cairo line 3156 at r6 (raw file):

    // update_rewards - test rewards only for token A
    system.update_rewards(:staker, disable_rewards: false);

test also staker rewards please

[cursor]

Bug: Wrong expected rewards used for token B validation

The test calculates expected_delegator_rewards using token A's parameters (delegation_amount_a, token_a_decimals, token_a.contract_address()) at lines 3163-3174, but then uses this value to validate token B's rewards at line 3206. Since token A has 8 decimals with min_for_rewards of 10³ and token B has 18 decimals with min_for_rewards of 10¹³, the expected rewards will be incorrect. The test needs to recalculate expected rewards using token B's configuration before the final assertion block.

Additional Locations (1)

• src/flow_test/test.cairo#L3162-L3174

 

[arad-starkware]

Reviewable status: 0 of 3 files reviewed, 7 unresolved discussions (waiting on @noa-starkware)

---

src/flow_test/test.cairo line 3094 at r6 (raw file):

Previously, noa-starkware wrote…

test also staker rewards please

Done.

---

src/flow_test/test.cairo line 3111 at r6 (raw file):

Previously, noa-starkware wrote…

test also staker rewards please

Done.

---

src/flow_test/test.cairo line 3120 at r6 (raw file):

Previously, noa-starkware wrote…

test also staker rewards please

Done.

---

src/flow_test/test.cairo line 3128 at r6 (raw file):

Previously, noa-starkware wrote…

// Enable token B, disable token A

Done

---

src/flow_test/test.cairo line 3148 at r6 (raw file):

Previously, noa-starkware wrote…

test also staker rewards please

Done.

---

src/flow_test/test.cairo line 3156 at r6 (raw file):

Previously, noa-starkware wrote…

test also staker rewards please

Done.

[cursor]

Bug: Staker commission uses wrong token's parameters for assertions

At line 3142, when token A becomes active (comment says "test rewards only for token A"), the staker_rewards assertion uses commission_rewards that was calculated for token B (lines 3109-3115). Similarly at line 3203, when token B becomes active, the assertion uses commission_rewards calculated for token A (lines 3162-3175). The staker commission should reflect the currently active token's pool, but the test reuses commission values calculated for the previously active token. This passes only due to the coincidental numerical equivalence after normalization.

Additional Locations (1)

• src/flow_test/test.cairo#L3202-L3203

 

[noa-starkware]

Comment why its ok

[arad-starkware]

Done

[noa-starkware]

@noa-starkware reviewed 1 of 2 files at r11.
Reviewable status: 1 of 3 files reviewed, 3 unresolved discussions (waiting on @arad-starkware)

---

src/flow_test/test.cairo line 3244 at r11 (raw file):

    system.staking.disable_token(token_address: token_a.contract_address());

    // Calculate rewards for consensus rewards

• only for one token enabled

---

src/flow_test/test.cairo line 3269 at r11 (raw file):

    // update_rewards - test rewards only for token A
    system.update_rewards(:staker, disable_rewards: false);

update_rewards twice before advance epoch?

[noa-starkware]

Comment why its ok

[arad-starkware]

Reviewable status: 1 of 3 files reviewed, all discussions resolved

---

src/flow_test/test.cairo line 3244 at r11 (raw file):

Previously, noa-starkware wrote…

• only for one token enabled

Done

---

src/flow_test/test.cairo line 3269 at r11 (raw file):

Previously, noa-starkware wrote…

update_rewards twice before advance epoch?

Done

[arad-starkware]

Done