Skip to content

Conversation

@arad-starkware
Copy link
Collaborator

@arad-starkware arad-starkware commented Nov 24, 2025

This change is Reviewable


Note

Adds a reusable Slack notification workflow and hooks it into the main branch pipeline to alert when the test job fails.

  • CI/CD:
    • New reusable workflow ./.github/workflows/notify-slack.yaml to send Slack alerts via incoming webhook on CI failure, parameterized by context_title and failed_job_name.
    • Main pipeline update in ./.github/workflows/on-merge.yaml:
      • Adds notify-slack job that runs after test and triggers only on failure, passing context for "main branch" and the failed job name.

Written by Cursor Bugbot for commit 193fe34. This will update automatically on new commits. Configure here.

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@arad-starkware arad-starkware self-assigned this Nov 24, 2025
@arad-starkware arad-starkware marked this pull request as ready for review November 24, 2025 13:27
@arad-starkware arad-starkware force-pushed the arad/ci_send_slack_message_when_ci_fails_on_main branch from a02f46a to ab7541d Compare November 24, 2025 13:29
@arad-starkware arad-starkware force-pushed the arad/ci_send_slack_message_when_ci_fails_on_main branch from ab7541d to 10fba23 Compare November 24, 2025 14:13
@arad-starkware arad-starkware force-pushed the arad/ci_send_slack_message_when_ci_fails_on_main branch 4 times, most recently from c348bf5 to 25f7f7f Compare November 24, 2025 14:47
#[test]
fn test_test() {
panic!("test");
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Accidentally committed failing test

The test test_test appears to be accidentally committed debugging code. It only contains panic!("test") which will always fail, preventing CI from passing.

Fix in Cursor Fix in Web

@arad-starkware arad-starkware force-pushed the arad/ci_send_slack_message_when_ci_fails_on_main branch from 25f7f7f to 5588a95 Compare November 24, 2025 14:53
@arad-starkware arad-starkware force-pushed the arad/ci_send_slack_message_when_ci_fails_on_main branch from 5588a95 to 193fe34 Compare November 24, 2025 15:27
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.63%. Comparing base (407cf62) to head (193fe34).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #60   +/-   ##
=======================================
  Coverage   95.63%   95.63%           
=======================================
  Files          45       45           
  Lines        9859     9859           
=======================================
  Hits         9429     9429           
  Misses        430      430           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@NirLevi-starkware NirLevi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@NirLevi-starkware reviewed 4 of 4 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noa-starkware)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants