[5.x] Use deep copy of objects in replicator set #11621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faltjo
changed the title
jasonvarga
requested changes
Mar 25, 2025
There was a problem hiding this comment.
Can you please change clone(value) to JSON.parse(JSON.stringify(value)) ? And let me know if that still resolves the issue on your site.
We a bunch of changes regarding clone() in the current v6 branch, and I don't want this to accidentally get reverted. Better to be explicit here for now.
|
Sure. It still resolves the issue, I added the commit accordingly. |
duncanmcclean
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #11619
Instead of a shallow copy, a deep copy of the (default) values is used when adding or duplicating an item in the replicator-set.
Unfortunately I do not know how to test this in an automated way.
When using statamic from this branch, the problems are gone in the example repo: https://github.com/faltjo/replicator-set-bug