Hipcub warp threads deprecation #763
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudhu2k
force-pushed
the
hipcub_warp_threads_deprecation
branch
from
9ed6ba1 to
673c80b
Compare
|
Hi @tridao @albertfgu, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Future proofing by changing the
WARP_THREADSmacro definition to arocprim::arch::wavefront::max_size(), since rocprim::warp_size()` function will be removed or deprecated in future versions of ROCm.What's Changed
csrc/selective_scan/reverse_scan.cuh, the definition ofWARP_THREADShas been updated for the ROCm build path.rocprim::arch::wavefront::max_size(), which correctly resolves the warp size.Why It's Important
The
rocprim::warp_size()function will be removed or deprecated in future versionsHow to Test
This is a build-time fix for future ROCm versions