-
Notifications
You must be signed in to change notification settings - Fork 297
Gloas beacon block validation update #7657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
Conversation
| # If `execution_payload` verification of block's execution payload parent by | ||
| # an execution node **is complete** | ||
| debugGloasComment("update is_execution_block") | ||
| if signed_beacon_block.is_execution_block: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to
nimbus-eth2/beacon_chain/gossip_processing/gossip_validation.nim
Lines 929 to 934 in b2276f6
| # Implementation restrictions: | |
| # | |
| # - We don't know if the parent state had execution enabled. | |
| # If it had, and the block doesn't have it enabled anymore, | |
| # we end up in the pre-Merge path below (`else`) and REJECT. | |
| # Such a block is clearly invalid, though, without asking the EL. |
It seems that we need some sort of refactoring for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nimbus-eth2/beacon_chain/gossip_processing/gossip_validation.nim
Lines 362 to 367 in b2276f6
| # The condition: | |
| # [REJECT] The block's parent (defined by `block.parent_root`) passes all | |
| # validation (excluding execution node verification of the | |
| # `block.body.execution_payload`). | |
| # cannot occur here, because Nimbus's optimistic sync waits for either | |
| # `ACCEPTED` or `SYNCING` from the EL to get this far. |
No description provided.