Skip to content

Conversation

@ahshum
Copy link
Contributor

@ahshum ahshum commented Oct 22, 2025

No description provided.

Comment on lines 411 to 414
# If `execution_payload` verification of block's execution payload parent by
# an execution node **is complete**
debugGloasComment("update is_execution_block")
if signed_beacon_block.is_execution_block:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to

# Implementation restrictions:
#
# - We don't know if the parent state had execution enabled.
# If it had, and the block doesn't have it enabled anymore,
# we end up in the pre-Merge path below (`else`) and REJECT.
# Such a block is clearly invalid, though, without asking the EL.

It seems that we need some sort of refactoring for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# The condition:
# [REJECT] The block's parent (defined by `block.parent_root`) passes all
# validation (excluding execution node verification of the
# `block.body.execution_payload`).
# cannot occur here, because Nimbus's optimistic sync waits for either
# `ACCEPTED` or `SYNCING` from the EL to get this far.

@github-actions
Copy link

github-actions bot commented Oct 22, 2025

Unit Test Results

       15 files  ±0    3 030 suites  ±0   1h 29m 22s ⏱️ +14s
12 067 tests ±0  11 497 ✔️ ±0  570 💤 ±0  0 ±0 
76 511 runs  ±0  75 659 ✔️ ±0  852 💤 ±0  0 ±0 

Results for commit 1a9ec88. ± Comparison against base commit 0ae66b3.

♻️ This comment has been updated with latest results.

@ahshum ahshum changed the title Gloas beacon block validation update for v1.6.0-beta.1 Gloas beacon block validation update Oct 23, 2025
@ahshum ahshum marked this pull request as draft October 30, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant