Skip to content

chore: replace FIXME comment to resolve linting warning (issue #7336) #7346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

RUSHILPATEL33
Copy link

@RUSHILPATEL33 RUSHILPATEL33 commented Jun 13, 2025

Resolves #7336

Description

What is the purpose of this pull request?

This pull request updates a FIXME comment to comply with the no-warning-comments ESLint rule. The comment was reworded using a neutral tone to eliminate the lint warning.

Related Issues

Does this pull request have any related issues?

Resolves #7336

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No additional details.

Checklist

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Jun 13, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
wasm/module-wrapper $\color{red}314/512$
$\color{green}+61.33\%$
$\color{red}3/7$
$\color{green}+42.86\%$
$\color{red}1/14$
$\color{green}+7.14\%$
$\color{red}314/512$
$\color{green}+61.33\%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented Jun 13, 2025

@RUSHILPATEL33 Thank you for your interest in contributing to stdlib; however, we cannot accept your contribution, as the FIXME is intentional, and the comment you replace it with is not applicable.

Thank you again for your interest, and we look forward to your future contributions.

@kgryte kgryte closed this Jun 13, 2025
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors
3 participants