Skip to content

chore: fix editorconfig lint errors (issue #7335) #7348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 14, 2025
Merged

chore: fix editorconfig lint errors (issue #7335) #7348

merged 7 commits into from
Jun 14, 2025
+4 −0

Conversation

Deepak91168
Copy link
Contributor

Resolves #7335

Description

What is the purpose of this pull request?

This pull request:

  • Fixes indentation issue

Related Issues

Does this pull request have any related issues?

No

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
image
image

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Deepak91168
chore: fix EditorConfig lint errors (issue stdlib-js#7335
9ff3350 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Deepak91168
Revert "chore: fix EditorConfig lint errors (issue stdlib-js#7335"
fc9ba3a 
This reverts commit 9ff3350.
@Deepak91168
chore: fix EditorConfig lint errors (issue stdlib-js#7335)
4f259e5 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Deepak91168
Revert "chore: fix EditorConfig lint errors (issue stdlib-js#7335)"
9355372 
This reverts commit 4f259e5.
@Deepak91168
chore: fix EditorConfig lint errors (issue stdlib-js#7335)
5cab8c0 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Jun 13, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jun 13, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
lapack/base/sge-trans $\color{green}349/349$
$\color{green}+100.00\%$ 		$\color{green}19/19$
$\color{green}+100.00\%$ 		$\color{green}3/3$
$\color{green}+100.00\%$ 		$\color{green}349/349$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Deepak91168 Deepak91168 changed the title chore: Fix EditorConfig lint errors (issue #7335) chore: fix editorconfig lint errors (issue #7335) Jun 13, 2025
@udaykakade25
Copy link
Contributor

Use small case for the title. So last CI check can pass easily!

@Deepak91168
Copy link
Contributor Author

Use small case for the title. So last CI check can pass easily!

Thanks!
Updated was running in queue...

kgryte
kgryte reviewed Jun 14, 2025
View reviewed changes
kgryte
kgryte reviewed Jun 14, 2025
View reviewed changes
kgryte
kgryte approved these changes Jun 14, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this particular case, the mixed indentation is intentional, as we want element alignment. As such, I reverted the proposed changes and simply disabled the linter for this specific block.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jun 14, 2025
@kgryte kgryte merged commit 58679fa into stdlib-js:develop Jun 14, 2025
10 checks passed
@Deepak91168
Copy link
Contributor Author

In this particular case, the mixed indentation is intentional, as we want element alignment. As such, I reverted the proposed changes and simply disabled the linter for this specific block.

Thanks for confirming!

@Deepak91168 Deepak91168 deleted the fixJS branch June 14, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Good First PR A pull request resolving a Good First Issue. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix EditorConfig lint errors
4 participants
@Deepak91168 @stdlib-bot @udaykakade25 @kgryte