fix(concurrency): send command metatypes safely - #22
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
steipete
force-pushed
the
codex/swift64-sendable-bindings
branch
from
August 13, 2026 09:37
869de59 to
321412d
Compare
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(concurrency): send command metatypes safely This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SendableMetatypeforParsableCommandon Swift 6.2 and newer instead of making every mutable command instanceSendableSendablerequirement for Swift 6.0 and 6.1 compilersWhy
Commander only transfers command type metadata across isolation domains. Command instances are created, bound, and executed on the main actor. Requiring instance-level
Sendablemade a split-fileParsableCommandadoption synthesize a retroactive conformance, which Swift 6.4 diagnoses and plans to reject in a future language mode.This models the actual ownership boundary without
@unchecked Sendableor consumer-side mechanical conformance moves.Proof
swift test -Xswiftc -warnings-as-errors— 65 tests pass with Apple Swift 6.4Sendablediagnostics before; zero afterSwift 6.2 is the first compiler with
SendableMetatype; it was not installed on the local proof host. Commander CI continues to exercise the Swift 6.2+ branch with its configured Swift 6.3.3 toolchain.