Skip to content

Conversation

@leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Jan 6, 2026

What

Replace custom backoff-based transaction polling logic with the Go Stellar SDK's built-in PollTransaction method.

Why

The go-stellar-sdk is getting PollTransaction functionality in stellar/go-stellar-sdk#5876, which is a port over of the polling transaction logic in friendbot. Now that the logic has been incorporated into the SDK, that eliminates the need for that logic to live and be maintained here.

Dependent on:

@socket-security
Copy link

socket-security bot commented Jan 6, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedgithub.com/​stellar/​go-stellar-sdk@​v0.1.0 ⏵ v0.0.0-20260106225531-c77f40a164fb75 +1100100100100

View full report

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the transaction polling implementation by replacing custom backoff-based polling logic with the Go Stellar SDK's built-in PollTransaction method. This change eliminates maintenance burden and leverages battle-tested SDK functionality.

Key Changes:

  • Replaced custom pollTransactionStatus function with SDK's PollTransaction method
  • Removed direct dependency on cenkalti/backoff/v4 package (now indirect via SDK)
  • Updated to a development version of go-stellar-sdk that includes the PollTransaction method

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
internal/rpcnetworkclient/client.go Simplified transaction submission by replacing custom polling loop with SDK's PollTransaction method; removed backoff import and polling constants
go.mod Updated go-stellar-sdk to development version; moved backoff package to indirect dependencies
go.sum Updated checksums for go-stellar-sdk version change

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@leighmcculloch
Copy link
Member Author

Ready for review and merging.

This PR now depends on a specific commit of go-stellar-sdk (c77f40a164fb) rather than a released version in order to use the new PollTransactionWithOptions functionality. This is fine because there's nothing incompatible on the main branch of go-stellar-sdk since the last release, and friendbot would like to use this functionality now without being blocked on a release.

@leighmcculloch leighmcculloch marked this pull request as ready for review January 6, 2026 23:03
Copy link
Contributor

@urvisavla urvisavla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@leighmcculloch leighmcculloch merged commit cb007c8 into update-repo Jan 9, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants