-
Notifications
You must be signed in to change notification settings - Fork 543
Add core protocol version to GetNetworkResponse struct #5877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for querying Soroban network limits from stellar-core's sorobaninfo endpoint. It introduces new data structures to represent Soroban network configuration limits and protocol version information, which are then exposed through the RPC's getNetwork response.
- Adds
SorobanInfoResponsestruct with comprehensive Soroban network limits and configuration settings - Implements
SorobanInfo()client method to query the stellar-coresorobaninfoendpoint - Updates
GetNetworkResponseto include protocol versions and Soroban limits
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| protocols/stellarcore/info_response.go | Adds SorobanInfoResponse struct with nested structures for transaction limits, ledger limits, fees, state archival settings, and SCP settings; fixes incomplete comment on IsSynced() |
| protocols/rpc/get_network.go | Adds GetProtocolVersions struct and updates GetNetworkResponse to include protocol versions and Soroban limits from stellar-core |
| clients/stellarcore/client.go | Implements SorobanInfo() method to call stellar-core's sorobaninfo endpoint; includes minor formatting cleanup (line breaks) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e0ba6c4 to
0481c28
Compare
…to add-SorobanInfoResponse-struct
What
This PR adds a field for the core protocol version to the GetNetworkResponse struct.
Why
Known limitations
N/A