Skip to content

Conversation

@cjonas9
Copy link
Contributor

@cjonas9 cjonas9 commented Dec 5, 2025

What

This PR adds a field for the core protocol version to the GetNetworkResponse struct.

Why

Known limitations

N/A

@cjonas9 cjonas9 marked this pull request as ready for review December 6, 2025 00:53
Copilot AI review requested due to automatic review settings December 6, 2025 00:53
@cjonas9 cjonas9 requested a review from a team December 6, 2025 00:53
@cjonas9 cjonas9 changed the title Added struct for Soroban network limits Added struct for Soroban network limits and protocol version info Dec 6, 2025
@cjonas9 cjonas9 changed the title Added struct for Soroban network limits and protocol version info Add struct for Soroban network limits and protocol version info Dec 6, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for querying Soroban network limits from stellar-core's sorobaninfo endpoint. It introduces new data structures to represent Soroban network configuration limits and protocol version information, which are then exposed through the RPC's getNetwork response.

  • Adds SorobanInfoResponse struct with comprehensive Soroban network limits and configuration settings
  • Implements SorobanInfo() client method to query the stellar-core sorobaninfo endpoint
  • Updates GetNetworkResponse to include protocol versions and Soroban limits

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
protocols/stellarcore/info_response.go Adds SorobanInfoResponse struct with nested structures for transaction limits, ledger limits, fees, state archival settings, and SCP settings; fixes incomplete comment on IsSynced()
protocols/rpc/get_network.go Adds GetProtocolVersions struct and updates GetNetworkResponse to include protocol versions and Soroban limits from stellar-core
clients/stellarcore/client.go Implements SorobanInfo() method to call stellar-core's sorobaninfo endpoint; includes minor formatting cleanup (line breaks)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cjonas9 cjonas9 force-pushed the add-SorobanInfoResponse-struct branch from e0ba6c4 to 0481c28 Compare December 8, 2025 21:48
@cjonas9 cjonas9 changed the title Add struct for Soroban network limits and protocol version info Add to core protocol version to GetNetworkResponse struct Dec 10, 2025
@cjonas9 cjonas9 changed the title Add to core protocol version to GetNetworkResponse struct Add core protocol version to GetNetworkResponse struct Dec 10, 2025
@sreuland sreuland changed the base branch from master to main December 11, 2025 00:25
@cjonas9 cjonas9 requested a review from a team January 6, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants