Set DOCKER_HOST to colima so that macos-13 emulator tests work #1997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabethengelman
force-pushed
the
ee/troubleshoot
branch
7 times, most recently
from
b33a9fd to
1615adc
Compare
elizabethengelman
force-pushed
the
ee/troubleshoot
branch
from
909e217 to
8a64214
Compare
elizabethengelman
changed the title
elizabethengelman
merged commit 9171fb3
into
emulator-multiplatform
34 of 35 checks passed
elizabethengelman
added a commit
that referenced
this pull request
Apr 29, 2025
* Enable multiplatform ledger tests * Set DOCKER_HOST to colima socket for macos(#1997) --------- Co-authored-by: Elizabeth Engelman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ifropc I think that this change should get the emulator tests running on macos-13. The last run took 32min, but i had noticed it being quicker in previous attempts, so it may need some fine tuning still.
What
Set the DOCKER_HOST to the colima host and pipe to github env
Why
the emulator tests were failing on macos because we need to account for colima's socket being different than the default docker socket. and the test containers library (and it's dep bollard) were expecting the socket to be at the default docker host.
Known limitations
the cargo deny failure should be fixed once
emulator-multiplatformand this branch are updated with main.