additional-libs feature for ledger-stellar dependencies (ledger signing) #2011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabethengelman
changed the title
elizabethengelman
changed the base branch from
main
to
feat/additional-libs-feature
elizabethengelman
force-pushed
the
feat/add-ledger-to-addition-libs
branch
from
7cf11d3 to
8f77b52
Compare
elizabethengelman
force-pushed
the
feat/add-ledger-to-addition-libs
branch
from
c81cf6f to
eaf6652
Compare
elizabethengelman
force-pushed
the
feat/add-ledger-to-addition-libs
branch
from
53cd5a5 to
502b3a9
Compare
ifropc
approved these changes
Apr 17, 2025
Contributor
ifropc
left a comment
ifropc
left a comment
There was a problem hiding this comment.
Looks pretty straightforward given changes in another additional-libs PR.
LGTM!
elizabethengelman
force-pushed
the
feat/add-ledger-to-addition-libs
branch
from
1f6215f to
be45079
Compare
elizabethengelman
merged commit a7e96f5
into
feat/additional-libs-feature
34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Based on #1977, this PR adds support for including the
ledger-stellarcrate in the additional-libs feature.Why
Allows for a smaller binary, and less system dependencies.
Known limitations
N/A