Skip to content

Conversation

@leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Nov 3, 2025

What

Move the doc-gen binary code into its own crate, separate from the soroban-cli crate, and have it be dependent on the unmerged pull request to clap-markdown that adds support for grouping cli options:

Why

The grouped options experience is a massive improvement. It makes the help documentation easier to scan and understand. It's the way the options are organised on the command line and the help markdown documentation should follow suite. While the pull request adds the feature upstream, the pull request hasn't been accepted yet.

The clap-markdown dependency isn't needed for the stellar-cli other than doc-gen, so it is in any case good to get the dependency outside of the soroban-cli crate, so that it isn't downloaded by cargo everytime someone installs the stellar-cli. Moving doc-gen into its own crate is trivial because the soroban-cli is designed to be embedded, and achieves that. Additionally because the doc-gen crate does not need to be published it can reference the unreleased pull request without issue.

@github-project-automation github-project-automation bot moved this to Backlog (Not Ready) in DevX Nov 3, 2025
@leighmcculloch leighmcculloch marked this pull request as ready for review November 3, 2025 02:19
@leighmcculloch leighmcculloch enabled auto-merge (squash) November 3, 2025 02:19
@leighmcculloch leighmcculloch requested a review from a team November 3, 2025 02:30
Copy link
Contributor

@marcelosalloum marcelosalloum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leighmcculloch leighmcculloch merged commit 8508cce into main Nov 3, 2025
29 of 30 checks passed
@leighmcculloch leighmcculloch deleted the doc-gen-options-grouped branch November 3, 2025 21:42
@github-project-automation github-project-automation bot moved this from Backlog (Not Ready) to Done in DevX Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants