fix(ts-bindings): options is MethodOptions
#2306
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an update to stellar#2283, which changed hard-coded `options` to `AssembledTransactionOptions`. This was not quite correct, it should be a `MethodOptions`. This works together with stellar/js-stellar-sdk#1293 to finally remove the need for `@ts-expect-error` lines in our canonical write-method invocation examples.
Member
|
Closed via #2305 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This is an update to #2283, which changed hard-coded
optionstoAssembledTransactionOptions. This was not quite correct, it should bea
MethodOptions.Why
This works together with
stellar/js-stellar-sdk#1293 to finally remove
the need for
@ts-expect-errorlines in our canonical write-methodinvocation examples.
Known limitations
Same as #2283