feat: add expandAssets param to offers and multisig-info endpoint - #598
Merged
Sulex45 merged 2 commits intoJul 26, 2026
Merged
Conversation
…heck-multisig example
- GET /account/:id/offers?expandAssets=true embeds full { code, issuer, type }
asset objects under selling.asset and buying.asset on each offer.
Default behaviour (omitted) returns simplified spread fields — backward-compatible.
- GET /account/:id/multisig-info returns isMultisig, masterWeight,
thresholds (low/med/high), and full signers list with normalized types.
- examples/check-multisig.js: dependency-free runnable script that calls
/account/:id/multisig-info and prints a formatted human-readable summary
of the account's signing setup. Usage: node examples/check-multisig.js G...
- tests/account.offers.expandAssets.test.js: covers both default and
expanded modes, native/credit assets, and expandAssets=false fallback.
- tests/account.multisigInfo.test.js: covers happy path, single-signer,
threshold-based isMultisig detection, type normalisation, 404, and 400.
- Fix pre-existing duplicate const declarations (cacheService, cacheTTL)
at the top of src/routes/account.js.
|
@Hovibby Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…heck-multisig example
GET /account/:id/offers?expandAssets=true embeds full { code, issuer, type } asset objects under selling.asset and buying.asset on each offer. Default behaviour (omitted) returns simplified spread fields — backward-compatible.
GET /account/:id/multisig-info returns isMultisig, masterWeight, thresholds (low/med/high), and full signers list with normalized types.
examples/check-multisig.js: dependency-free runnable script that calls /account/:id/multisig-info and prints a formatted human-readable summary of the account's signing setup. Usage: node examples/check-multisig.js G...
tests/account.offers.expandAssets.test.js: covers both default and expanded modes, native/credit assets, and expandAssets=false fallback.
tests/account.multisigInfo.test.js: covers happy path, single-signer, threshold-based isMultisig detection, type normalisation, 404, and 400.
Fix pre-existing duplicate const declarations (cacheService, cacheTTL) at the top of src/routes/account.js.
Description
Linked Issue
Closes #
Type of Change
Testing Notes
Checklist
closes #588
closes #584