fix: add missing name attribute for details html element #6188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
I wanted to use the
details
html element with thename
property in Stencil's TSX and got the error:The
name
property seems to be missing here:core/src/declarations/stencil-public-runtime.ts
Line 922 in 30fc9f5
The
name
attribute is part of the web standard and allows grouping multipledetails
elements: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details#multiple_named_disclosure_boxesGitHub Issue Number: N/A
What is the new behavior?
The name attribute is added to the definitions and can be used in TSX.
Documentation
Does this introduce a breaking change?
Testing
Other information