-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update self-collision barrier unit test #129
Open
stephane-caron
wants to merge
2
commits into
main
Choose a base branch
from
fix/safety_zone_test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephane-caron
added a commit
that referenced
this pull request
Apr 11, 2025
stephane-caron
added a commit
that referenced
this pull request
Apr 11, 2025
bc9513d
to
d8c1f2a
Compare
stephane-caron
added a commit
that referenced
this pull request
Apr 11, 2025
d8c1f2a
to
705eae3
Compare
stephane-caron
added a commit
that referenced
this pull request
Apr 11, 2025
705eae3
to
670cbf9
Compare
9ba3020
to
45c03f7
Compare
@domrachev03 Do you agree that this update tests what we want to test here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR investigates #130.
Failing unit test
The test considers the following collision pair:
Indeed, pair 24 is between bodies
iiwa_link_2_0
andiiwa_link_3_1
of the iiwa14 description:However, the test checks
h[self.colliding_objects_pair_id]
, where the ordering of the barrier vectorh
depends on sorted distances:If this analysis is correct,
h[self.colliding_objects_pair_id]
may not correspond to the distance for pair 24 after sorting, so it will not necessarily be negative 🤔Proposed update
This PR updates the test to:
h
is negative (as there is a self-collision)