fix: create log directory before running agent container (#168)#213
Open
kaixinbaba wants to merge 1 commit into
Open
fix: create log directory before running agent container (#168)#213kaixinbaba wants to merge 1 commit into
kaixinbaba wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #168
Problem
The
run-job.ymlworkflow fails because the Docker container expects alogs/{JOB_ID}directory to exist on the host volume, but the workflow never creates it. This causes:Error: ENOENT: no such file or directory, open 'logs/.../stdout.log'Fix
Add a "Prepare log directory" step before the Docker run step that creates the required directory:
This ensures the directory exists before the agent container tries to write logs to it.