fix: set world-writable permissions on cluster log dir and files (#203)#220
Open
kaixinbaba wants to merge 1 commit into
Open
fix: set world-writable permissions on cluster log dir and files (#203)#220kaixinbaba wants to merge 1 commit into
kaixinbaba wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
The cluster worker container runs as the
claude-codeuser, while the host process (inlib/cluster/execute.js) runs asroot. When the root process creates the log directory and writes initial files (system-prompt.md,user-prompt.md,meta.json,trigger.json), they are created with restrictive permissions that prevent the worker container from:stdout.jsonl,stderr.txt)meta.json)Solution
Added
fs.chmodSync()calls to make files and directories world-writable:fs.mkdirSync(logDir, { recursive: true })→ addfs.chmodSync(logDir, 0o777)fs.writeFileSync()for log files → add correspondingfs.chmodSync(filePath, 0o666)This allows the worker container to read, write, and update all log files without permission errors.
Changed Files
lib/cluster/execute.js: Added 5chmodSynccallsTesting
node --check lib/cluster/execute.js✓