Skip to content

Conversation

@thedewil
Copy link

@thedewil thedewil commented Jun 9, 2020

Check /api/v3/getPublicPageData and compare "spaceDomain" with local variable.

Check /api/v3/getPublicPageData and compare "spaceDomain" with local variable.
@nickjstevens
Copy link

This will address issue #45.

@nickjstevens
Copy link

It would be even better if instead of throwing an error it landed on a custom 404 page.

@stephenou
Copy link
Owner

stephenou commented Oct 31, 2020

unfortunately returning an error from getPublicPageData doesn't hide the content of the page :/

https://square-glade-e805.stephenou.workers.dev/

image

(I used a random string for SPACE_DOMAIN in my test)

#18 doesn't work either because the space map is no longer in recordMap in the response of loadPageChunk.

Anyone has a better idea?

@simple10
Copy link

simple10 commented Apr 20, 2022

#65

Rather than checking getPublicPageData API the notion site domain can be used instead of www.notion.so in the fetchAndApply function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants