Add MD progress bar #521
Merged
Add MD progress bar #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 16, 2025
|
( |
ElliottKasoar
force-pushed
the
md-progress-show-all
branch
2 times, most recently
from
41e01b8 to
5461b59
Compare
Currently working in general, but likely doesn't behave properly with ramp restarts, and if the update frequency isn't a multiple of the total bar widths, they won't fill up completely.
ElliottKasoar
force-pushed
the
md-progress-show-all
branch
from
5461b59 to
655efc9
Compare
oerc0122
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #405 and #455
See examples for the next week: https://asciinema.org/a/gQeyJo9JJPvSWFkuLVCkdnfHV
Or permanent example:
This combines aspects of #444 and #457.
Thanks to @k-harris27, we do now have the option to use ASE's
irun, and wrap this with therichprogress tracker, but unfortunately this seems to provide limited options for reducing the frequency of updates, since eachnext(irun)causes the bar to refresh. This ends up having a noticeable (consistently 4-5% from tests up to around 25 min on my laptop) impact on performance, so I think we need to limit the frequency of updates, which requires a more manual process.To simplify things, I've gone with a single progress bar, but the description changes according to the current step.