[WIP] Isochronous transfer support #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used to allocate 9 * 16 words minimum, no matter how many tx endpoints where active. Now we only account for memory allocated to enabled Tx endpoints when determining how much has already been used.
Per RM0383's OTG documentation, when we receive an IISOIXFR interrupt we must disable and re-enable the IN endpoint and flush its FIFO before retransmitting.
dgoodlad
added a commit
to dgoodlad/crabdac
that referenced
this pull request
Aug 9, 2022
I've implemented it upstream in stm32-rs/synopsys-usb-otg#29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is a
WIPbut wanted to put it out there for feedback sooner rather than later. Maintainers please feel free to close this PR if you'd prefer not to have it sitting openDepends on rust-embedded-community/usb-device#60 for upstream support in
usb-device.Significant changes
INtransfers set the even/odd frame bit inDIEPCTLbefore transmitting.IISOIXFRMinterrupt, we must follow the procedure documented in the reference manual to reset the endpoint.This has only been tested so far on two devices,
F411andF446. The former was running in FS, the latter in HS. I've only used it for very small transfers to support USB Audio Class 2 feedback channels pumping a single floating point value back to the host each frame. It does work for that use case at least 😄Remaining work
INto get it merged first)usb-deviceon how to implement & test isochronous endpoints to get Add enumerations and allocator for isochronous endpoints rust-embedded-community/usb-device#60 merged