Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InternalHubComponent rbac to the policy-addon #1932

Conversation

JustinKuli
Copy link
Contributor

Refs:

Description

Add InternalHubComponent rbac to the policy-addon.

Related Issue

https://issues.redhat.com/browse/ACM-14707

Changes Made

Add InternalHubComponent rbac to the policy-addon.

Screenshots (if applicable)

Add screenshots or GIFs that demonstrate the changes visually, if relevant.

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • I have added/updated relevant unit tests (if applicable).
  • I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2

Definition of Done

  • Code is reviewed.
  • Code is tested.
  • Documentation is updated.
  • All checks and tests pass.
  • Approved by at least one reviewer.
  • Merged into the main/master branch.

@JustinKuli JustinKuli force-pushed the 14707-grc-internalhubcomponent-rbac branch from 69eb392 to c736276 Compare January 24, 2025 04:34
@openshift-ci openshift-ci bot removed the approved label Jan 24, 2025
@JustinKuli JustinKuli force-pushed the 14707-grc-internalhubcomponent-rbac branch from c736276 to 88c02f9 Compare January 24, 2025 04:42
@JustinKuli
Copy link
Contributor Author

@yiraeChristineKim
Copy link
Contributor

/cc @gparvin

@openshift-ci openshift-ci bot requested a review from gparvin January 24, 2025 06:59
@dislbenn
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dislbenn, JustinKuli, yiraeChristineKim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5ff32d0 into stolostron:main Jan 24, 2025
10 checks passed
@JustinKuli JustinKuli deleted the 14707-grc-internalhubcomponent-rbac branch January 24, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants