Skip to content

Codacy issue cleanup #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gb119 merged 2 commits into from
Feb 10, 2026
Merged

Codacy issue cleanup #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26d0b67
Replace pass with ellipsis in abstract methods
gb119 Feb 10, 2026
4dbdfec
Refine notes on multi-platform coverage tracking
gb119 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions CODE_REVIEW.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ No high-priority issues found.
- **Current**: 73% coverage (merged from all platforms via Coveralls and Codacy)
- **Target**: 85%+ coverage
- **Recommendation**: Add more unit tests for error handling code paths
- **Note**: Platform-specific code (Windows, Darwin) is now properly tracked via multi-platform coverage merging with Coveralls and Codacy
- **Note**: Platform-specific code (Windows, Darwin) is now properly tracked via multi-platform
coverage merging with Coveralls and Codacy

---

Expand Down Expand Up @@ -145,7 +146,8 @@ No high-priority issues found.
- `bad_path/platforms/darwin.py`: Coverage tracked on macOS CI
- `bad_path/platforms/windows.py`: Coverage tracked on Windows CI

**Note**: With Coveralls and Codacy integration, platform-specific code coverage is now properly tracked and merged from all CI platforms (Linux, Windows, macOS).
**Note**: With Coveralls and Codacy integration, platform-specific code coverage is now properly
tracked and merged from all CI platforms (Linux, Windows, macOS).

### Missing Test Coverage

Expand Down
4 changes: 2 additions & 2 deletions bad_path/checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,12 +386,12 @@ def __init__(
@abstractmethod
def _load_invalid_chars(self) -> None:
"""Load platform-specific invalid characters and reserved names."""
pass
...

@abstractmethod
def _load_and_check_paths(self) -> None:
"""Load system and user paths, then check the current path against them."""
pass
...

def _is_dangerous(self) -> bool:
"""Check if the path is dangerous based on current settings.
Expand Down
Loading